Update arm APIVersionPattern rule for canonical swagger #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinwa-ms
requested review from
AkhilaIlla,
bdefoy,
mikeharder,
rkmanda,
tejaswiMinnu and
weshaggard
as code owners
Member
Author
|
@rkmanda @mikeharder, could you help take a look at this PR when available? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is for Issue 707 : Update the version format check for canonical swagger #707.
We introduced canonical swagger. It is a union of versioned swaggers. The version of canonical swagger will be "canonical", which will fail the existing APIVersionPattern. In this PR, we updated the rule for this scenario. If the swagger is generated by autorest-canonical emitter, it is canonical swagger and its version should be 'canonical'. Otherwise, its version should follow the existing rule.